Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(FileUpload): Missing form label (a11y) #15138

Merged

Conversation

SoyDiego
Copy link
Contributor

@SoyDiego SoyDiego commented Mar 21, 2024

Fix #15137

Added aria-label and translations to avoid the accessibility problem.
I solved the 4 missing form label because are affecting the components, the rest of the errors showing in the screenshot are from others things in the website but is not related with the component in this case.

CURRENTLY

image

AFTER THIS CHANGES

image

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 3:14pm

@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu merged commit b2d1e9f into primefaces:master Mar 22, 2024
3 checks passed
@cetincakiroglu cetincakiroglu removed this from the 17.13.0 milestone Apr 9, 2024
@SoyDiego SoyDiego deleted the fix-accessibility-fileupload branch May 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileUpload: Missing form label (a11y)
2 participants